fix(Select): fix checkAll option in group mode #3941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uyarn
requested review from
HaixingOoO,
NWYLZW,
RylanBot,
ZWkang,
carolin913 and
honkinglin
as code owners
commit: |
Contributor
|
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the "select all" functionality in grouped Select components. When using option groups with a "checkAll" option, the component now correctly includes options from groups in the calculation of selectable items.
Key Changes
- Modified the
onCheckAllChangefunction inSelect.tsxto handle nested options within option groups - Fixed the initial state calculation for the "checkAll" checkbox in
Option.tsx - Added optional chaining for safe access to options array in the
onRemovehandler - Added a test case to verify the grouped select "checkAll" functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/components/select/base/Select.tsx | Updated onCheckAllChange to iterate through grouped options and added safe navigation for options lookup |
| packages/components/select/base/Option.tsx | Fixed initial checkbox state calculation to use optionLength comparison |
| packages/components/select/tests/select.test.tsx | Added test case for grouped select with "checkAll" functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
RylanBot
approved these changes
Nov 3, 2025
HaixingOoO
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
fix(Select): 修复
1.15.7版本中全选功能在分组模式下功能异常的问题本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单